ming-devr — a list for ming developers and those interested in ming's guts

[Ming-dev] Decompiler bug: add, callMethod

[strk <st...@ke...>]

ActionScript:

   obj[a+'memb']();

flasm:

    push 0, 'obj'
    getVariable
    push 'a'
    getVariable
    push 'memb'
    add
    callMethod

decompiles to:

    obj.a+'memb'();

.. which is a syntax error ...


--strk; 

 ()   ASCII Ribbon Campaign
 /\   Keep it simple! 

Re: [Ming-dev] supply something to access FILE argument?

[Klaus R. <kla...@rz...>]

Hi,

Am Donnerstag 13 Dezember 2007 12:17:09 schrieb oyster:
> currently, some function in ming needs a FILE pointer, which is hard
> for script languae(for example python) to use.
[...]
> 1. why not offer a peer function which only needs fielname, but act as
> those needs a FILE pointer. Yes, there are some in the src, but not
> all.
All newer ming-functions take filenames instead of FILE pointer. One major 
drawback of file pointers is, that you have to keep them open until the movie 
is written. In bindings like php or python they also often leak. 

The API will slowly change that way.

    Klaus

[Ming-dev] supply something to access FILE argument?

[oyster <lep...@gm...>]

currently, some function in ming needs a FILE pointer, which is hard
for script languae(for example python) to use.
I found that there is something like
[C code]
/* added by David McNab <da...@re...> */
/* required so that python can pass in file descriptors instead of
FILE* streams */

SWFSound
newSWFSoundFromFileno(int fd, byte flags)
{
  FILE *fp = fdopen(fd, "r");
  return newSWFSound(fp, flags);
}
[/code]

so, my question is:
1. why not offer a peer function which only needs fielname, but act as
those needs a FILE pointer. Yes, there are some in the src, but not
all.
I have tested, but only get error message(see below), so can anyone check it?

2. or, in ming sourcecode, to offer a function, which takes the
filename then return a FILE pointer, then we don't have to modify the
ming heavily
[C code]
FILE *name2file(const char *filename)
{
	return fopen(filename, "rb");
}

int closeit(FILE *f)
{
	return fclose(f);
}
[/C code]

I have compiled ming-0.4.0.beta5 on win2k with mingw. Most of the test
runs ok, but after running test01.exe and test02.exe under
ming-0.4.0.beta5\test\Movie\setSoundStream\, there no flash file is
created, and there is no error message
When I translate the above C code to python with
[python]
f=open('some.flv', 'rb')
newSWFSoundStreamFromFileno(f.fileno())
[/python]
I get
[msg]
stream = newSWFSoundStreamFromFileno(fFile.fileno())
WindowsError: exception: access violation reading 0x00000034]
[/msg]

btw, I am program python-ming interface via ctypes
[python]
import os, sys
def setpath():
    u=os.path.realpath(__file__)
    u=os.path.split(u)[0]
    u=os.path.normpath(u)

    if ' ' in u:
        u='"%s"' % u
    if os.environ.has_key('PATH'):
        os.environ['PATH']='%s;%s' % (u, os.environ['PATH'])
    else:
        os.environ['PATH']=u

setpath()

NULL=0


from ctypes import *

################for name2file#####################
class _FILE(Structure):
    pass

FILE_PTR = POINTER(_FILE)

_name2file = CDLL('name2file.dll')

name2file = _name2file.name2file
name2file.restype = FILE_PTR
name2file.argtypes = [c_char_p]

closeit = _name2file.closeit
closeit.restype = c_int
closeit.argtypes = [FILE_PTR]


#############for ming################################
class SWFMovie_s(Structure):
    pass
SWFMovie_s._fields_ = [
]
SWFMovie = POINTER(SWFMovie_s)

class SWFSoundStream_s(Structure):
    pass
SWFSoundStream = POINTER(SWFSoundStream_s)
SWFSoundStream_s._fields_ = [
]

ming = CDLL('libming-0.dll')

newSWFMovieWithVersion = ming.newSWFMovieWithVersion
newSWFMovieWithVersion.restype = SWFMovie
newSWFMovieWithVersion.argtypes = [c_int]

newSWFSoundStream = ming.newSWFSoundStream
newSWFSoundStream.restype = SWFSoundStream
newSWFSoundStream.argtypes = [POINTER(_FILE)]

newSWFSoundStreamFromFileno = ming.newSWFSoundStreamFromFileno
newSWFSoundStreamFromFileno.restype = SWFSoundStream
newSWFSoundStreamFromFileno.argtypes = [c_int]

SWFMovie_setSoundStream = ming.SWFMovie_setSoundStream
SWFMovie_setSoundStream.restype = None
SWFMovie_setSoundStream.argtypes = [SWFMovie, SWFSoundStream]

SWFMovie_nextFrame = ming.SWFMovie_nextFrame
SWFMovie_nextFrame.restype = None
SWFMovie_nextFrame.argtypes = [SWFMovie]

SWFMovie_save = ming.SWFMovie_save
SWFMovie_save.restype = c_int
SWFMovie_save.argtypes = [SWFMovie, c_char_p]

def main():
    m = newSWFMovieWithVersion(7);


    if 0:
        fFile = name2file('../test/Media/video02.flv')
        print fFile
        stream = newSWFSoundStream(fFile)
    else:
        fFile = open('../test/Media/video02.flv')
        stream = newSWFSoundStreamFromFileno(fFile.fileno())


    SWFMovie_setSoundStream(m, stream)
    for i in range(200):
        SWFMovie_nextFrame(m)

    SWFMovie_save(m, "test02.swf")

main()
[/python]

[Ming-dev] Download link on ming.sourceforge.net

[Klaus R. <kl...@re...>]

Hi,

could someone please remove the ming-0.3 download link form 
ming.sourceforge.net ? People are still downloading this version. Thus we 
loose testers for current releases and disappoint new users with old bugs...

Thanks 
	Klaus 

Re: [Ming-dev] actionscript code generation bugHi

[Albrecht K. <kl...@ak...>]

Hi Klaus,

>     121:SWFACTION_SETVARIABLE
>     122:SWFACTION_END

> Looks OK for me. What did i miss ?

Thank you, Klaus.
You didn´t miss anything.  It was my fault: a local perl path 
problem here. The perl interpreter did not notice the new installed library 
in /usr/local/lib/perl5   but  the old one was still used in /usr/lib/perl5.....

Now it works very well :)

Cheers,
Albrecht

Re: [Ming-dev] actionscript code generation bugHi

[Klaus R. <kl...@re...>]

Hi,

your script produces the following output with current CVS-HEAD:

<snip>
Offset: 36 (0x0024)
Block type: 12 (SWF_DOACTION)
Block length: 81

 11 Actions
    42:SWFACTION_CONSTANTPOOL
     [000] xtext
     [001] Math
     [002] abs
    62:SWFACTION_PUSH
     [000]   Constant: 0 "xtext"
     [001]   Integer: 4
     [002]   Integer: 3
    77:SWFACTION_LESS2
    78:SWFACTION_IF
    BranchOffset: 13, TargetOffset: 96
    2 Action
    83:SWFACTION_PUSH
     [000]   Integer: 6
    91:SWFACTION_JUMP
    BranchOffset: 8, TargetOffset: 104
    96:SWFACTION_PUSH
     [000]   Integer: 5
    104:SWFACTION_PUSH
     [000]   Integer: 1
     [001]   Constant: 1 "Math"
    114:SWFACTION_GETVARIABLE
    115:SWFACTION_PUSH
     [000]   Constant: 2 "abs"
    120:SWFACTION_CALLMETHOD
    121:SWFACTION_SETVARIABLE
    122:SWFACTION_END

<snap>

Looks OK for me. What did i miss ?

	Klaus


Am Samstag 01 Dezember 2007 20:49:47 schrieb Albrecht Kleine:
> Hi Klaus,
> 
> maybe I did something wrong, but the patch didn't help.
> If you want test it yourself, here is the Perl script I used:
> 
> 
> #!/usr/bin/perl -w
> use SWF qw(:ALL);
> SWF::setVersion(7);
> my $m = new SWF::Movie();
> my $font = new SWF::Font("_sans");
> my $tf = new SWF::TextField();
> $tf->setFont($font);
> $tf->setName("xtext");
> $tf->setHeight( 40);
> $tf->setBounds(150,150);
> $m->add($tf);
> $m->add(new SWF::Action(
> <<ENDACTION
>  xtext=Math.abs(3>4? 5:6);
> ENDACTION
> ));
> $m->nextFrame();
> $m->save("test.swf");
> __EOF__
> 
> Thank you once again!
> 
> Cheers,
> Albrecht
> 
> -------------------------------------------------------------------------
> SF.Net email is sponsored by: The Future of Linux Business White Paper
> from Novell.  From the desktop to the data center, Linux is going
> mainstream.  Let it simplify your IT future.
> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> _______________________________________________
> Ming-devr mailing list
> Min...@li...
> https://lists.sourceforge.net/lists/listinfo/ming-devr
> 

Re: [Ming-dev] actionscript code generation bug

[Albrecht K. <kl...@ak...>]

Hi Klaus,

maybe I did something wrong, but the patch didn't help.
If you want test it yourself, here is the Perl script I used:


#!/usr/bin/perl -w
use SWF qw(:ALL);
SWF::setVersion(7);
my $m = new SWF::Movie();
my $font = new SWF::Font("_sans");
my $tf = new SWF::TextField();
$tf->setFont($font);
$tf->setName("xtext");
$tf->setHeight( 40);
$tf->setBounds(150,150);
$m->add($tf);
$m->add(new SWF::Action(
<<ENDACTION
 xtext=Math.abs(3>4? 5:6);
ENDACTION
));
$m->nextFrame();
$m->save("test.swf");
__EOF__

Thank you once again!

Cheers,
Albrecht

Re: [Ming-dev] actionscript code generation bug

[Klaus R. <kla...@rz...>]

Hi,

thanks for your report!
The reason for this behavior is ming tries to combine all push-values to a 
single push op. In the reported special case it does not make sense to do 
so...

In CVS-HEAD is a fix for IF() ... ELSE ... and ?:

Could you give it a try ? Thanks!

	Klaus

Am Freitag 30 November 2007 20:16:47 schrieb Albrecht Kleine:
> Hi,
>
> if you compile a line like this:
>
>    xtext=abs(3>4? 5:6);
>
> the Ming as compiler seems to generate invalid code,
> listswf tells us as follows:
>
>     66:SWFACTION_PUSH
>      [000]   Constant: 0 "xtext"
>      [001]   Integer: 4
>      [002]   Integer: 3
>     81:SWFACTION_LESS2
>     82:SWFACTION_IF
>     BranchOffset: 13, TargetOffset: 100
>     2 Action
>     87:SWFACTION_PUSH
>      [000]   Integer: 6
>     95:SWFACTION_JUMP
>     BranchOffset: 8, TargetOffset: 108<------ jump just into operation
>     100:SWFACTION_PUSH
>      [000]   Integer: 5
>      [001]   Integer: 1
>      [002]   Constant: 1 "Math"
>     115:SWFACTION_GETVARIABLE
>     116:SWFACTION_PUSH
>      [000]   Constant: 2 "abs"
>     121:SWFACTION_CALLMETHOD
>
> To compare I tried MTASC with better results:
>
>     255:SWFACTION_PUSH
>      [000]   Constant: 5 "xtext"
>      [001]   Integer: 3
>      [002]   Integer: 4
>     270:SWFACTION_GREATER
>     271:SWFACTION_IF
>     BranchOffset: 13, TargetOffset: 289
>     2 Action
>     276:SWFACTION_PUSH
>      [000]   Integer: 6
>     284:SWFACTION_JUMP
>     BranchOffset: 8, TargetOffset: 297
>     289:SWFACTION_PUSH
>      [000]   Integer: 5
>     297:SWFACTION_PUSH<--------------------- an additional PUSH here
>      [000]   Integer: 1
>      [001]   Constant: 6 "Math"
>     307:SWFACTION_GETVARIABLE
>     308:SWFACTION_PUSH
>      [000]   Constant: 7 "abs"
>     313:SWFACTION_CALLMETHOD
>
> As we can see, the 3rd PUSH should be splitted into 2 operations.
>
> Does someone could solve this problem ???
>
> Cheers
> Albrecht
>
> -------------------------------------------------------------------------
> SF.Net email is sponsored by: The Future of Linux Business White Paper
> from Novell.  From the desktop to the data center, Linux is going
> mainstream.  Let it simplify your IT future.
> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> _______________________________________________
> Ming-devr mailing list
> Min...@li...
> https://lists.sourceforge.net/lists/listinfo/ming-devr

Re: [Ming-dev] './configure --prefix=/my/own/path' is ignored for perl extension

[peterdd <mi...@li...>]

> Makefile.perl is generated from Makefile.PL
> using this command (in Makefile.am rule):
>
> Makefile.perl: Makefile.PL
>         srcdir=$(srcdir) builddir=$(abs_builddir) $(PERL) $<
> MAKEFILE=Makefile.perl
>
> There's no explicit setting for install dir in Makefile.PL, I belive it all
> comes from $(PERL) itself ...
You can pass a bunch of parameters to perl Makefile.PL

See man ExtUtils::MakeMaker 

I changed the line in Makefile.am to 

Makefile.perl: Makefile.PL
	srcdir=$(srcdir) builddir=$(abs_builddir) $(PERL) PREFIX=$(prefix) $< 
FIRST_MAKEFILE=Makefile.perl

and it seems to work. So there is maybe no need to tinker with environment 
variables in Makefile.PL itself?



There is too no parameter MAKEFILE in ExtUtils::MakeMaker but it seems to 
accept it nevertheless. I found following in man ExtUtils::MakeMaker:

FIRST_MAKEFILE
The name of the Makefile to be produced.  This is used for the second Makefile 
that will be produced for the MAP_TARGET.

Defaults to Makefile or Descrip.MMS on VMS.
(Note: we couldn't use MAKEFILE because dmake uses this for something else).

Please test.

peterdd