[qooxdoo-contrib-commit] SF.net SVN: qooxdoo-contrib:[21074] trunk/qooxdoo-contrib/SVG/trunk/source/ class/svg/path/Path.js

[<mar...@us...>]

Revision: 21074
          http://qooxdoo-contrib.svn.sourceforge.net/qooxdoo-contrib/?rev=21074&view=rev
Author:   marcputs
Date:     2011-04-22 16:29:50 +0000 (Fri, 22 Apr 2011)

Log Message:
-----------
Fixed bug and potential memory leak in Path element when PathData was used.

Modified Paths:
--------------
    trunk/qooxdoo-contrib/SVG/trunk/source/class/svg/path/Path.js

Modified: trunk/qooxdoo-contrib/SVG/trunk/source/class/svg/path/Path.js
===================================================================
--- trunk/qooxdoo-contrib/SVG/trunk/source/class/svg/path/Path.js	2011-04-22 14:44:53 UTC (rev 21073)
+++ trunk/qooxdoo-contrib/SVG/trunk/source/class/svg/path/Path.js	2011-04-22 16:29:50 UTC (rev 21074)
@@ -76,20 +76,20 @@
     
     //applies path data
     _applyPathData: function(value, old) {
-      if (null == value) {
+      if (null === value) {
         this.removeAttribute("d");
-      } else if (value instanceof svg.path.PathData) {
-        
-        if (old instanceof svg.path.PathData) {
-          old.removeListener("change", this.__changeListener, this);
-        }
-        
+      }
+      else if (value instanceof svg.path.PathData) {
         this.setAttribute("d", value.toString());
         value.addListener("change", this.__changeListener, this);
-        
-      } else {
+      }
+      else {
         this.setAttribute("d", value);
       }
+      
+      if (old instanceof svg.path.PathData) {
+        old.removeListener("change", this.__changeListener, this);
+      }
     },
     
     //applies path length
@@ -108,7 +108,7 @@
      *   data event fired by PathData
      */
     __changeListener: function(ev) {
-      this._applyPathData(ev.getData());
+      this._applyPathData(ev.getData(), ev.getOldData());
     }
 
   }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.