Menu

Source Code Merge Request #5: Android cosl/sinl etc workaround (open)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Artyom Beilis wants to merge 1 commit from /u/artyom-beilis/libnova/ to master, 2024-11-09

Hello, on Android at least arm8 cosl is borken and leads to incorrect conversions between epochs. I disovered it as part of poring indi software stack that uses libnova to Android.

I added a simple workaround - use cos/sin instead of cosl/sinl.

Thanks

Commit Date  
[d5af5d] (android_fix) by Artyom Beilis Artyom Beilis

Fixed issue with cosl not calculating properly on Android

2024-11-01 13:06:00 Tree

Discussion

  • lheller

    lheller - 2024-11-09

    Hi,
    @Artyom-Beilis

    As far as I know, the author (Peter Kubanek) migrated the full repo from here to gitlab, so this one is not maintained anymore.
    Gitlab repo:
    https://gitlab.com/libnova/libnova

    BR,

    Ladislav

     
  • Artyom Beilis

    Artyom Beilis - 2024-11-09

    Looks like both repos have same latest update 2016-10-24. 655bcd

    I don't have an account in gitlab, I have SF and github. Since they are in sync it seems is is mergable to any location need.

    Can it be handled?

    I work on porting indi that used libnova to Android and it is a major issue.

     
    • lheller

      lheller - 2024-11-09

      You mean indi library & drivers for controlling astronomy equipment from Android? Sounds interesting. Do you have any progress on that? Maybe something I can test?

      Anyway, you can contact the author of libnova by email and directly ask him:
      pkubanek@gmail.com

       
  • Artyom Beilis

    Artyom Beilis - 2024-11-09

    You mean indi library & drivers for controlling astronomy equipment from Android? Sounds interesting. Do you have any progress on that? Maybe something I can test?

    Sure I already published a week ago first beta release of my App that runs indi:

    https://github.com/artyom-beilis/OpenLiveStacker/releases/tag/beta36

    Here some discussion on indi forum: https://indilib.org/forum/development/14981-putting-indi-drivers-to-a-library-to-run-on-android.html

    I currently ported only telescope drivers since most cameras require proprietary SDK and special modifications to run on Android (due to permission models). From what I understand same for most common focusesrs

    But at least for my needs (mount control), indi works and I anyway access camera directly via camera specific SDKs.

     

Log in to post a comment.

MongoDB Logo MongoDB