|
From: SourceForge.net <no...@so...> - 2007-01-17 21:49:55
|
Bugs item #1637020, was opened at 2007-01-16 18:44 Message generated for change (Comment added) made by pak21 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=596648&aid=1637020&group_id=91293 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Gergely Szasz (szaszg) >Assigned to: Philip Kendall (pak21) Summary: never free microdrive cartridge data Initial Comment: if1_init alloc 8 microdrive cartridge, but never free This patch fix this memory leak and change the C99 struct initialization to C89... ---------------------------------------------------------------------- >Comment By: Philip Kendall (pak21) Date: 2007-01-17 21:49 Message: Logged In: YES user_id=29214 Originator: NO Personally, I'm not too bothered about this sort of thing: we allocate the memory once at startup, and it will be freed by the OS on program exit (which happens about 10 microseconds after the call to if1_end() anyway). We, and the libraries we use, do plenty of this. That said, it doesn't do any harm to free it (unless you fail to put the prototype in if1.h, hint hint), so I've applied this. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=596648&aid=1637020&group_id=91293 |