cclib-devel — Developer's mailing list

Re: [cclib-devel] Regression test code back main repo?

[Eric B. <er...@pi...>]

Great! I will catch up on everything tonight.

On Mon, Aug 28, 2017 at 12:54 PM, Karol Langner <kar...@gm...>
wrote:

> So I'm going to go forward with this. Opened issue to track:
> https://github.com/cclib/cclib-data/issues/72
> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcclib%2Fcclib-data%2Fissues%2F72&data=01%7C01%7Cerb74%40pitt.edu%7Cdf52b2290577470a954808d4ee3581c7%7C9ef9f489e0a04eeb87cc3a526112fd0d%7C1&sdata=sJs%2FOB0bGbINuT%2BeXwY05ll53P%2FGVyBPvkJDcoH905s%3D&reserved=0>
>
> On Mon, Aug 14, 2017 at 9:59 AM, Karol Langner <kar...@gm...>
> wrote:
>
>> I've been thinking about moving the regression test code back to the main
>> 'cclib' repository. We moved it over to cclib-data to make the repos more
>> independent, but ultimately I think it wasn't worth it. Here are some
>> reasons:
>> 1. There is a still dependence between cclib and cclib-data, which the
>> move was supposed to solve, so it didn't really solve anything. Namely, we
>> still need to submit a bug fix before the regression test code goes in.
>> 2. I think having the test code along with the fix is better value than
>> having the test alongside the data.
>>
>> Let me know if you have any reservation, otherwise I'll prepare the move
>> for v1.5.2. I'd like to prepare the new release as GSOC comes to a close so
>> that it includes all of Sagar's work during the summer.
>>
>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! https://na01.safelinks.
> protection.outlook.com/?url=http%3A%2F%2Fsdm.link%2Fslashdot&data=01%7C01%
> 7Cerb74%40pitt.edu%7Cdf52b2290577470a954808d4ee3581c7%
> 7C9ef9f489e0a04eeb87cc3a526112fd0d%7C1&sdata=
> vaMBgluT3QYtS2qAodC44P4qBcYU2jEyXoOKqtiqUos%3D&reserved=0
> _______________________________________________
> cclib-devel mailing list
> ccl...@li...
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.
> sourceforge.net%2Flists%2Flistinfo%2Fcclib-devel&data=
> 01%7C01%7Cerb74%40pitt.edu%7Cdf52b2290577470a954808d4ee3581c7%
> 7C9ef9f489e0a04eeb87cc3a526112fd0d%7C1&sdata=
> LWkoFaH1ZLVQ2TQ3dsxh219xHBvk03ypehjy7nqpJHg%3D&reserved=0
>
>

Re: [cclib-devel] Regression test code back main repo?

[Karol L. <kar...@gm...>]

So I'm going to go forward with this. Opened issue to track:
https://github.com/cclib/cclib-data/issues/72

On Mon, Aug 14, 2017 at 9:59 AM, Karol Langner <kar...@gm...>
wrote:

> I've been thinking about moving the regression test code back to the main
> 'cclib' repository. We moved it over to cclib-data to make the repos more
> independent, but ultimately I think it wasn't worth it. Here are some
> reasons:
> 1. There is a still dependence between cclib and cclib-data, which the
> move was supposed to solve, so it didn't really solve anything. Namely, we
> still need to submit a bug fix before the regression test code goes in.
> 2. I think having the test code along with the fix is better value than
> having the test alongside the data.
>
> Let me know if you have any reservation, otherwise I'll prepare the move
> for v1.5.2. I'd like to prepare the new release as GSOC comes to a close so
> that it includes all of Sagar's work during the summer.
>

[cclib-devel] Regression test code back main repo?

[Karol L. <kar...@gm...>]

I've been thinking about moving the regression test code back to the main
'cclib' repository. We moved it over to cclib-data to make the repos more
independent, but ultimately I think it wasn't worth it. Here are some
reasons:
1. There is a still dependence between cclib and cclib-data, which the move
was supposed to solve, so it didn't really solve anything. Namely, we still
need to submit a bug fix before the regression test code goes in.
2. I think having the test code along with the fix is better value than
having the test alongside the data.

Let me know if you have any reservation, otherwise I'll prepare the move
for v1.5.2. I'd like to prepare the new release as GSOC comes to a close so
that it includes all of Sagar's work during the summer.

Re: [cclib-devel] Look at old PRs?

[Karol L. <kar...@gm...>]

It actually bothers me quite a bit, but I haven't had the energy to follow
up on everything. To be fair, some of the long standing PRs have resulted
in merging code in. But I agree, we should review all open PRs and and
decide what to do. If there are PRs we'd like to hold off for some reason,
we can mark them with a 1.6 or 2.x milestone.

On Sun, Aug 13, 2017 at 1:34 PM, Eric Berquist <er...@pi...> wrote:

> Hello everyone,
>
> I noticed a week ago that when Jan Jensen tweeted out a link to cclib's
> GitHub page, someone responded:
>
> yikes! PRs over a year old!
>>
>
> https://twitter.com/ifndef_define/status/894490849521930240
>
> While this doesn't bother me too much, I think that we should make a
> decision about all outstanding PRs for both main repositories before 1.5.2
> is released. Does everyone else agree?
>
> Eric
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> cclib-devel mailing list
> ccl...@li...
> https://lists.sourceforge.net/lists/listinfo/cclib-devel
>
>

[cclib-devel] Look at old PRs?

[Eric B. <er...@pi...>]

Hello everyone,

I noticed a week ago that when Jan Jensen tweeted out a link to cclib's
GitHub page, someone responded:

yikes! PRs over a year old!
>

https://twitter.com/ifndef_define/status/894490849521930240

While this doesn't bother me too much, I think that we should make a
decision about all outstanding PRs for both main repositories before 1.5.2
is released. Does everyone else agree?

Eric