#95 Argument "usb_fiq" isn't numeric in addition (+) at ./irq.pl line 89.

[VSC55]

Module irq send email error:
Cron root@host /etc/webmin/sysstats/sysstats.pl
Argument "usb_fiq" isn't numeric in addition (+) at ./irq.pl line 89.

# cat /proc/interrupts
           CPU0       CPU1       CPU2       CPU3
 16:          0          0          0          0  bcm2836-timer   0 Edge      arch_timer
 17:     862954     702627     667375    1214875  bcm2836-timer   1 Edge      arch_timer
 23:       9793          0          0          0  ARMCTRL-level   1 Edge      3f00b880.mailbox
 24:       3512          0          0          0  ARMCTRL-level   2 Edge      VCHIQ doorbell
 46:          0          0          0          0  ARMCTRL-level  48 Edge      bcm2708_fb dma
 48:          0          0          0          0  ARMCTRL-level  50 Edge      DMA IRQ
 50:          0          0          0          0  ARMCTRL-level  52 Edge      DMA IRQ
 51:     402723          0          0          0  ARMCTRL-level  53 Edge      DMA IRQ
 54:        200          0          0          0  ARMCTRL-level  56 Edge      DMA IRQ
 59:          0          0          0          0  ARMCTRL-level  61 Edge      bcm2835-auxirq
 62:   19241553          0          0          0  ARMCTRL-level  64 Edge      dwc_otg, dwc_otg_pcd, dwc_otg_hcd:usb1
 79:          0          0          0          0  ARMCTRL-level  81 Edge      3f200000.gpio:bank0
 80:          0          0          0          0  ARMCTRL-level  82 Edge      3f200000.gpio:bank1
 86:     303025          0          0          0  ARMCTRL-level  88 Edge      mmc0
 87:       5111          0          0          0  ARMCTRL-level  89 Edge      uart-pl011
 92:       4131          0          0          0  ARMCTRL-level  94 Edge      mmc1
FIQ:              usb_fiq
IPI0:          0          0          0          0  CPU wakeup interrupts
IPI1:          0          0          0          0  Timer broadcast interrupts
IPI2:     476234     520570     503745     738427  Rescheduling interrupts
IPI3:         49         57         44         40  Function call interrupts
IPI4:          0          0          0          0  CPU stop interrupts
IPI5:     103436      87004      70223     230641  IRQ work interrupts
IPI6:          0          0          0          0  completion interrupts

The SO is Debian in to Raspberry PI 3.

I have created a patch to correct the problem.
It's my first time with Perl so I'm sure the code can be improved.

Apply patch:
#patch /usr/share/webmin/sysstats/modules/irq/irq.pl < irq.patch

[eric gerbier]

Thanks for the patch !
I will integrate it with some little changes in webminstat's repository .

[MobileHero]

Hi, how can I apply that patch? When trying to, I get:

patching file /usr/share/webmin/sysstats/modules/irq/irq.pl
patch unexpectedly ends in middle of line
Hunk #2 FAILED at 87.
1 out of 2 hunks FAILED -- saving rejects to file /usr/share/webmin/sysstats/modules/irq/irq.pl.rej

Usually I wouldn´t care, but... I set up ssmtp and now I get those eMails EVERY MINUTE (!) Don´t know how/where to configure this, but would prefer to simply fix the root cause. How is it going (bringing it to the repository so the fix could be applied by normal users)?

[VSC55]

I'm sorry, the patch is broken.
I have already corrected it, and tested OK
#patch /usr/share/webmin/sysstats/modules/irq/irq.pl < irq.patch

Source: sysstats-2.17.tgz

[MobileHero]

Hmm... it´s the same code right? Anyway, after running the patch...

patching file /usr/share/webmin/sysstats/modules/irq/irq.pl
Reversed (or previously applied) patch detected!  Assume -R? [n] n
Apply anyway? [n] y
Hunk #1 FAILED at 26.
Hunk #2 succeeded at 87 (offset 1 line).
1 out of 2 hunks FAILED -- saving rejects to file /usr/share/webmin/sysstats/modules/irq/irq.pl.rej

the error seems to be gone. At least the last eMail a few minutes ago was a positive one ("alarm recovery on module filesopen").

Not 100 % sure yet, but: thank you :-)

[VSC55]

To verify that the patch has been applied correctly, you can check a couple of lines from the file "/usr/share/webmin/sysstats/modules/irq/irq.pl"

In line 29 is added, "use Scalar :: Util qw (looks_like_number);".
In line 90 is added, "if (looks_like_number ($ tab2 [$ i])) {".

If you see those two modifications, the problem is solved.

[eric gerbier]

I have work this week on the irq module. The code already has a is_unsigned_int function (in sysstats-gen-lib.pl), so I use it, instead adding a new module dependency.
Can you test this code and tell me if it works for you ?

[VSC55]

I have copied the new file, and at the moment there are no errors.

[eric gerbier]

The new release is available to test (in beta status) in https://sourceforge.net/projects/webminstats/files/Sysstats-devel/2.18c/

[VSC55]

Ok, Thank.