shk.c:4733: bad precedence ?

Brought to you by: j_ali, wacko

#962 shk.c:4733: bad precedence ?

Milestone: CVS

Status: open

Owner: nobody

Labels: None

Priority: 5

Updated: 2022-04-19

Created: 2022-04-19

Creator: dcb

Private: No

I just compiled the package with new C compiler clang-14.
It said:

./shk.c:4733:27: warning: & has lower precedence than ==; == will be evaluated first [-Wparentheses]

Source code is

if (ESHK(shkp)->services & (SHK_ID_BASIC|SHK_ID_PREMIUM) ==
        SHK_ID_BASIC|SHK_ID_PREMIUM) {

Maybe better code:

if ((ESHK(shkp)->services & (SHK_ID_BASIC|SHK_ID_PREMIUM)) ==
        SHK_ID_BASIC|SHK_ID_PREMIUM) {