#48 Non-portable use of sed(1) in Makefile

[Alexey Dokuchaev]

When performing CRLF->LF conversion on rhashrc.sample file, it is done via sed -e 's/\x0D//g', which works with GNU sed(1), but not necessarily other implementations (e.g. it does not work on FreeBSD).

There is a better way to strip CR's, by using tr(1) instead, which should work practically everywhere. Consider the following pseudo-patch:

-       sed -e 's/\x0D//g' dist/rhashrc.sample > rc.tmp && $(INSTALL_DATA) ...
+       tr -d \\r < dist/rhashrc.sample > rc.tmp && $(INSTALL_DATA) ...

[Aleksey]

Thank you for the patch!
The fix has been applied: https://github.com/rhash/RHash/commit/e6251fba6e70dd08237c0ea6f7e140463c108594

[Aleksey]

Fixed in v1.3.4