Menu

#21 Button Start/Pause behavior

Unstable
closed-accepted
None
5
2015-05-26
2015-04-30
No

Bug: When I make a second click on in button start / pause in the same place, the game ignores me.

Pause and play button were the opposite of intuition, when the running time display should pause button.

1 Attachments

Discussion

  • Duong Khang NGUYEN

    • assigned_to: Duong Khang NGUYEN
     
  • Duong Khang NGUYEN

    Hi there,

    Could you please explain the following part of your patch:

    Index: src/guibutton.cpp

    --- src/guibutton.cpp (revisión: 472)
    +++ src/guibutton.cpp (copia de trabajo)
    @@ -166,8 +166,9 @@
    static int myX, myY;

    // Return immediatly if this is NOT visible
    - if ( IsSet( OC_GUIMAIN_VISIBLE ) == false )
    - return;
    +// Always verify for calc if mouse is up.
    +/ if ( !IsSet( OC_GUIMAIN_VISIBLE ) )
    + return;
    /

    // The button must be contained in a guicontainer !
    assert( _pctr != NULL );

     
  • Juan Montesano

    Juan Montesano - 2015-05-25

    If the mouse is positioned over an invisible button, the button state is that the mouse is not up.
    If the button made visible and you click, nothing happens because the button is in the wrong state.

     
  • Duong Khang NGUYEN

    • status: open --> closed-accepted
     
  • Duong Khang NGUYEN

    Applied.

    Thank you for your help.

     

Log in to post a comment.