Reading measurement values from AoFile instance

Brought to you by: crechner, markus-renner

#7 Reading measurement values from AoFile instance

Milestone: Unstable (example)

Status: closed

Owner: Markus Renner

Labels: None

Priority: 5

Updated: 2023-10-20

Created: 2023-10-18

Creator: Masayoshi Kuroda

Private: No

Hi,

I made a patch for reading the ATFX file that uses AoFile instance for storeing binary file instead of ExternalComponent.filenameUrl.

1 Attachments

ExtCompReader.java.patch

Discussion

Masayoshi Kuroda - 2023-10-18

I attached complete ExtCompReader.java file.

ExtCompReader.java

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Markus Renner - 2023-10-18

Thank you, Kuroda-san! Would you mind creating one or a few unit tests as well for this additional functionality?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Masayoshi Kuroda - 2023-10-18

I attached new Test file.

ExtCompReaderAoFileTest.java

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Masayoshi Kuroda - 2023-10-18

and test data file.

external_with_flags_aofile.atfx

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Markus Renner - 2023-10-18

It seems the ExtCompFiles are missing, could you send me "external_with_flags.bda" and "external_with_flags_flags_extract.btf" referenced from that atfx file as well, please?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Markus Renner - 2023-10-18

The bda file is actually there, I assume you just reuse the existing one? The btf file, however, is new it seems and I will need it.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Masayoshi Kuroda - 2023-10-19

Iattached the flags binaryfile and fixed external_with_flags_aofile.atfx.

Put them into directory 'src\test\resources\de\rechner\openatfx'
and run 'ExtCompReaderAoFileTest.java'

external_with_flags_aofile.atfx

external_with_flags_flags_extract.btf

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Markus Renner - 2023-10-19

Version 1.3.4 is released including your new feature.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Markus Renner - 2023-10-19

status: open --> closed

assigned_to: Markus Renner
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Masayoshi Kuroda - 2023-10-20

Markus-san,
I appreciate your cooperation.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.