#9 Can't create AoExternalComponent since base model 33

[Michael Stoll]

Hi Christian,
i think we found another Bug, specially for the asam standards 33, 34, 35. Looks like it can't create the AoExternalComponent correctly for those standards. In association with a partner we updated the the libraries de.rechner.openatfx.io.AtfxReader class as following after line 528:

        // start_offset, since asam33 models
        if (!existingBaNames.contains("start_offset")) {
            ApplicationAttribute aa = aeExtComp.createAttribute();
            aa.setName("start_offset");
            aa.setBaseAttribute(aeExtComp.getBaseElement().getAttributes("start_offset")[0]);
        }
        // block_size, since asam33 models
        if (!existingBaNames.contains("block_size")) {
            ApplicationAttribute aa = aeExtComp.createAttribute();
            aa.setName("block_size");
            aa.setBaseAttribute(aeExtComp.getBaseElement().getAttributes("block_size")[0]);
        }
        //valuesperblock, since asam33 models
        if (!existingBaNames.contains("valuesperblock")) {
            ApplicationAttribute aa = aeExtComp.createAttribute();
            aa.setName("valuesperblock");
            aa.setBaseAttribute(aeExtComp.getBaseElement().getAttributes("valuesperblock")[0]);
        }
        //value_offset, since asam33 models
        if (!existingBaNames.contains("value_offset")) {
            ApplicationAttribute aa = aeExtComp.createAttribute();
            aa.setName("value_offset");
            aa.setBaseAttribute(aeExtComp.getBaseElement().getAttributes("value_offset")[0]);
        }

I think we should update the library here to support these attributes.

Best regards,
Michael Stoll

[Christian Rechner]

Hi,
thank you for the proposal. I added this code and released a new version.
Regards
Christian

[Michael Stoll]

Thank you.