Perforce versioning system fails when running sync command o

Status: Beta

Brought to you by: andycking, dsouders, dtor, dynofu, and 3 others

#163 Perforce versioning system fails when running sync command o

Milestone: v1.0 (example)

Status: open-fixed

Owner: nobody

Labels: kernel modules (60)

Priority: 8

Updated: 2015-07-09

Created: 2013-03-15

Creator: David Koudela

Private: No

Perforce versioning system fails when running sync command on hgfs filesytem.

The problem is that perforce client uses rename operation upon a temp file which has read-only attributes. The operation then fails with permission denied (see attached test application).

The fix we have provided removes the read only attribute and retries the rename operation again (see attached source code and diff). The same code is already there (see function HgfsDelete) – probably it is a good idea to refactor the retry procedure.

Could you please add this fix to the upstream of the VMware tools?
Thanks a lot,
David.

Discussion

David Koudela - 2013-03-15

Fixed Source Code

inode.c

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Koudela - 2013-03-15

Diff

inode.c.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Koudela - 2013-03-15

Test Application

hgfs-p4-test.c

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Koudela - 2013-03-15

priority: 5 --> 8
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dmitry Torokhov - 2013-03-15

Thank you David, I'll forward this on.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Steve - 2013-05-06

Hi David,
I currently work on the HGFS file system, and just got notice of this from dtor.

Thanks for looking into this, I will take a look at the modified file and run it through some checks and tests.
I recently ran some perforce sync in my Ubuntu VM running on my Windows 7 host.
I didn't see any issues of note, but I will retry and pay close attention.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Steve - 2013-05-06

David, I have reproduced this issue and will apply your diffs and yes, probably refactor since HgfsDelete does the same thing.

Thanks.
Steve

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Koudela - 2013-05-07

Hi Steve,
Thanks a lot!
David.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Koudela - 2013-09-11

Hi Steve,
Is there any update?
I see that VMware Workstation 10 has been recently released.
Is the fix included in this release?
Thanks,
David.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Koudela - 2014-04-03

Any update?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Ravindra Kumar - 2014-04-11
  
  Thanks for the patch David. I would like to confirm that your patch has been included in the upstream and you will see it in the next release of open-vm-tools.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ravindra Kumar - 2015-07-09

Please check with the latest release of open-vm-tools 9.10.2.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ravindra Kumar - 2015-07-09

status: open --> open-fixed

Group: --> v1.0 (example)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.