#1172 iconv issues on non-gnu systems

[Dan McMahill]

nsis 3.01 released code.
OS - NetBSD-7.0.2/amd64

I built nsis-3.01 from source and all seemed fine but it won't get far when it runs. It fails with NSISRT_Initialize failed!

The failure is because WCHAR_T is not an encoding in NetBSD's iconv which is based on citrus. My understanding is Solaris also does not support this. So even the command line iconv:

iconv -l | more

shows the calls to iconv_open("wchar_t", ....) are going to fail (and they do).

http://mail-index.netbsd.org/current-users/2016/07/21/msg029820.html has some info on why WCHAR_T can't be supported by the citrus iconv implementation and gives a suggestion on what programs can do.

Sorry for not providing a patch. I'm not fluent enough with iconv, character conversions, and c++ (old c programmer) to do a reasonable job.

Thanks
-Dan

[Anders]

At least for making NSISRT_Initialize work, we don't actually care if it is the encoding for wchar_t or something else, we just need a output encoding while we detect other stuff. You could try replacing all "wchar_t" strings in \Source\Util.cpp with "" or "UTF-8". You might also have to remove the /TRANSLIT suffix.

Utf.cpp will also have issues and there we actually want the encoding that the process uses for wchar_t strings. You could try replacing "wchar_t" with "UTF-32".

We clearly need a way to detect this instead of hardcoding but I could not even find any citrus iconv documentation so we can only do babysteps for now...