Menu ▾ ▴

#45 Flags short form not uniq in interface output

BETA-1.65-UPSTREAM
closed-fixed
nobody
None
5
2021-12-12
2021-12-11
Peter Radisson
No

The short form of flags for IFF_POINTOPOINT and IFF_PROMISC are the same character (see below). I found that bug when i was rewriting the flags output.

if (ptr->flags & IFF_POINTOPOINT)
    printf("P");
if (ptr->flags & IFF_PROMISC)
    printf("P");

Discussion

  • Mike Frysinger

    Mike Frysinger - 2021-12-12
    • summary: Flags short form not uniq --> Flags short form not uniq in interface output
    • status: open --> accepted
     

    • Bernd Eckenfels

      Bernd Eckenfels - 2021-12-12

      Can’t remember I think I was inspired by BSD tools but not sure. I would agree to change pointtopoint, because PROMISC might be more security critical (even when the linked patch modified it from M to P …)

       

      Last edit: Mike Frysinger 2021-12-12

  • Mike Frysinger

    Mike Frysinger - 2021-12-12

    this bug has been around for over 21 years ;). added via
    https://sourceforge.net/p/net-tools/code/ci/942d4debc340b0ea039483301088ff5e667009bf

    i don't know how the short flags were picked and whether they're related to anything else (like a command line option). if they're not, easiest thing is prob to change pointtopoint to lowercase p. i can't find any such relationship in the tree ...

     

  • Mike Frysinger

    Mike Frysinger - 2021-12-12
    • status: accepted --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB