#237 Loggingmacros.h no longer included in logger.h

[Chris Steenwyk]

In a previous version of the library the include:

#include <log4cplus/loggingmacros.h>

was at the bottom of the main file logging.h. This allowed me to include logging.h and also get the ability to log using the macros LOG4CPLUS_DEBUG, LOG4CPLUS_INFO, etc. In version 1.1 this is no longer the case, requiring me to also provide the above include after my include for logger.h.

Is this intentional? Is there a different main include I should use? It seems strange to me that I would always need to do:

#include <log4cplus/logger.h>
#include <log4cplus/loggingmacros.h>

[Václav Haisman]

Yes, this is intentional. I have found the cyclic dependencies between the two headers too untidy so I have broken the dependency by including logger.h in loggingmacros.h. Also, you can actually use log4cplus without the macros. From thi POV, including loggingmacros.h in logger.h is unnecessary.

[Václav Haisman]

• Description has changed:

Diff:

--- old
+++ new
@@ -1,8 +1,14 @@
 In a previous version of the library the include:
-\#include <log4cplus/loggingmacros.h>

-was at the bottom of the main file logging.h. This allowed me to include logging.h and also get the ability to log using the macros LOG4CPLUS\_DEBUG, LOG4CPLUS\_INFO, etc.  In version 1.1 this is no longer the case, requiring me to also provide the above include after my include for logger.h.
+~~~~~
+#include <log4cplus/loggingmacros.h>
+~~~~~
+
+was at the bottom of the main file logging.h. This allowed me to include logging.h and also get the ability to log using the macros `LOG4CPLUS_DEBUG`, `LOG4CPLUS_INFO`, etc.  In version 1.1 this is no longer the case, requiring me to also provide the above include after my include for logger.h.

 Is this intentional? Is there a different main include I should use? It seems strange to me that I would always need to do:
-\#include &lt;log4cplus/logger.h&gt;
-\#include &lt;log4cplus/loggingmacros.h&gt;
+
+~~~~~
+#include <log4cplus/logger.h>
+#include <log4cplus/loggingmacros.h>
+~~~~~

• milestone: --> beta

[Václav Haisman]

Ticket moved from /p/log4cplus/support-requests/36/