Menu

#59 kmalloc unchecked in amdtp.c

open
nobody
None
5
2003-04-16
2003-04-16
No

From:

http://kbugs.org/cgi-bin/index.py?page=source&version=2.5.67&file=drivers/ieee1394/amdtp.c&&script=Dereference&skernel=2.5.67&sfile=&start_bug=50&#line1216

The kmalloc there goes unchecked to see if it failed.
Unfortunately, looking through the code I can't
determine the correct solution. amdtp_add_host() has a
void return value, so returning -ENOMEM isn't feasible.
Changing the return type of amdtp_add_host() would
lead to lots of other complications, which I don't have
enough familiarity with the code to be able to handle.
So, sorry I can't provide a patch, but hopefully you
can figure out the appropriate fix.

Discussion


Log in to post a comment.

MongoDB Logo MongoDB