Menu

#3 Asset download handling is wrong

v0.7
closed-fixed
Network (3)
5
2012-05-24
2012-04-24
No

The function HandleTransferPacket() in AssetManager.java assumes that the incoming packets arrive in the correct order. This is not something that the underlaying UDP protocol can quarantee. The alternative to assume fixed size packet data sounds also rather suboptimal. The correct way (TM) would be to add the data chunks to a sorted Hashlist with the Packet number as hash (also making sure to only account for packets that are not already in the list) and when the transfer is complete to assemble the data chunks in the hashlist into the final data file.

Discussion

  •  Frederick Martian

    • status: open --> open-accepted
     
  •  Frederick Martian

    • status: open-accepted --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB