#42 Error while using smart-attach

[Guenter Walser]

Hi,

when trying to use smart attach first time I got the following issues:

# uno
in smart_attach.py spawnlp is used
According to Python Doc (docs.python.org/lib/os-process.html) this isn't available for Windows.
"Availability: Unix, Windows. spawnlp(), spawnlpe(), spawnvp() and spawnvpe() are not available on Windows. New in version 1.6."

# dos
dom = xml.dom.minidom.parseString( output )
runs totally unsecure, means no exception handling used to catch empty or otherwise strange data in output.

# tres (not sure if this is a functional extension ;-)
in the QT cleint is no picture shown of the attached file , in the GTK it is

rgds
obi

[Nobody/Anonymous]

Logged In: NO

Thanks for the report, but:
1) smart_attach server module is only intended to run under Linux/Unix. If you're willing to make it work under windows you can provide patches which we can commit to trunk.
2) True, I've commited a patch with exception handling around xml parsing code. Note there might be other unhandled exceptions though.
3) This is more or less intended. Our dialog is much more general as it's a normal view, and as such can be easily extended. Note however that KTiny's binary widget (the one that let's you pick up a file) has a context menu (right click on textbox) that let's you show the image or open the file. This is more powerful than GTK's solution as anywhere you need to attach a binary file you'll have those two options.