The plugin "Style">"Import ArcMap Style" needs an extra software called "ArcGIS-map to SLD Converter" available only for windows, downloadable here: https://arcmap2sld.i3mainz.hs-mainz.de/ArcMap2SLDConverter_Eng.htm
The software is downloadable with no installer while the OJ loading process requires the software to be installed at a specific folder: see method org.openjump.core.ui.plugin.style.ImportArcMapStylePlugIn.findArcMap2SLD(WorkbenchFrame wbframe, Blackboard bb).
It is possible to solve it (changing tthe method to link at a specific folder and adding a warning that informs user to create a folder, download the file and put in that folder).
The question is also complex as this additional software works only with Windows/requires a windows/Visual basic software. No support for Linux or OSX.
Even a possible solution (add a JFileChooser to select ArcMap2SLDConverter.exe seems not working.
Possible the plugin requires also a running ArcGIS session (too complicate...)
I think that such a plugin using native windows tools should be proposed as an external extension, not wrapped in OpenJUMP core what do you think ?
+1 for removal. we can keep the code in the plugin repo for reference. how about a clean cut and remove it in OJ2? will tag it as such for now. feel free to correct.
Currently, if i try to execute the plugin on my windows box, I get the folloing error :
java.io.IOException: Cannot run program "regedit": CreateProcess error=740, L’opération demandée nécessite une élévation
at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1128)
at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1071)
at org.openjump.core.ui.plugin.style.ImportArcMapStylePlugIn.findArcMap2SLD(ImportArcMapStylePlugIn.java:99)
at org.openjump.core.ui.plugin.style.ImportArcMapStylePlugIn.execute(ImportArcMapStylePlugIn.java:147)
I prepared an extension in the plug-ins section of the repo. I did not solve the previous problem but the extension compiles, it is loaded and it produces the exact same error as the internal version (see above). I extracted translations for en, de, es, fi, fr and it from the main language file.
Not sure it is worth keeping the current version in 1.16 if we don't solve/document the problem before migration:
committed a fix
fix #482: disable regedit call and always allow selection of ArcGIS_SLD_Converter.exe with the previous selected location preselected
let's keep it in OJ 1.16, but remove it in OJ 2.x where lot's of extensions will be missing anyway initially.
..ede
Peppe, this plugin is still present in OpenJUMP 2.0. Can you tell us where we are about this ticket ?
I will close this bug as not fixed, If you agree.
This plugin possibly will be never used as it requires an external software which works only in Windows and possibly it was never upgraded for a while.
We can leave the code in the repository as an external plug-in
Peppe
Last version at https://wald.intevation.org/frs/?group_id=32&release_id=892 seems to be about 5 years old. The converter would have some value if it worked but if nobody so far has managed to make is run I believe it is better to drop it.
even though it is still downloadable, the process to use does not seem to be straightforward as well https://gis.stackexchange.com/a/275133/41386 apart from being outdated.
i'll deactivate it.