#53 FindBugs Warning

[Marco Tulio Valente]

Dear all,

We are conducting an study about the relevance of the warnings reported by the FindBugs tool when executed over several open-source systems.

Particularly, in the case of Jext, we would like to confirm the relevance of the following warning reported by the tool (for version 5):

Location: org.gjt.sp.jedit.syntax.MakefileTokenMarker markTokensImpl
Warning: Dead store due to switch statement. A value stored in the previous switch case is overwritten here due to a switch fall through. It is likely that you forgot to put a break or return at the end of the previous case.

Location: org.jext.JextFrame loadProperties
Warning: Bad attempt to compute absolute value of signed 32-bit random integer. This code generates a random signed integer and then computes the absolute value of that random integer. If the number returned by the random number generator is Integer.MIN_VALUE, then the result will be negative as well (since Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE).

Location: org.jext.JextLoader <init>
Warning: Bad attempt to compute absolute value of signed 32-bit random integer.

Location: org.jext.gui.SplashScreen <init>
Warning: Bad attempt to compute absolute value of signed 32-bit random integer.

Location: org.jext.misc.AboutWindow <init>
Warning: Bad attempt to compute absolute value of signed 32-bit random integer.

Since these warnings seemed relevant to us, we would like to confirm our classification with Jext's developers.

Best regards,

Marco Tulio Valente
Brazil