Menu

#578 fix #2732 syntax highlighting broken if commenting starts in non-visible

None
pending-rejected
nobody
None
5
2016-03-24
2015-11-14
Eric Le Lay
No

This is a simple patch to invalidate (un)commented lines.
I'm not familiar with the TextArea code, si I'd appreciate a review.

line-comment is not affected, since its syntax highlighting is not context-sensitive so only visible lines need to be repainted, which is already done.

Fixes [#2732]

1 Attachments

Related

Bugs: #2732

Discussion

  • Eric Le Lay

    Eric Le Lay - 2015-11-14
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -2,3 +2,5 @@
     I'm not familiar with the TextArea code, si I'd appreciate a review.
    
     line-comment is not affected, since its syntax highlighting is not context-sensitive so only visible lines need to be repainted, which is already done.
    +
    +Fixes [#2732]
    
    • Group: -->
     
  • Marc Häfner

    Marc Häfner - 2016-03-23

    This does not seem to solve the problem. The relevant lines are already invalidated as a result of the final selectNone() which calls invalidateSelectedLines. (But since you made me look into it there is now patch [#580])

     

    Related

    Patches: #580

  • Eric Le Lay

    Eric Le Lay - 2016-03-24
    • status: open --> pending-rejected
     
  • Eric Le Lay

    Eric Le Lay - 2016-03-24

    yes ideed, my patch doesn't seem to help.
    yours (#580) seems to work.

    Steps to reproduce:
    1. open jEdit/build.xml
    2. select from <project to="" <="" description="" 3.="" scroll="" down="" to="" hide="" <project="" but="" show="" <="" description="" 4.="" Edit=""> Code > Range comment
    5. no syntax highlighting of the comment

     

Log in to post a comment.