Menu

#577 patch for #3939 VFSBrowser callbacks after directory change

None
pending-rejected
None
5
2017-10-29
2015-11-08
Eric Le Lay
No

Patch for [#3939]
I'm not familiar with the Tasks & VFSBrowser code, so the patch is very open for review :-)

It fixes VFSFileNameField.doComplete(), removes unused VFSFileNameField.goToParent().
I think there are no similar issues of use waitForIoTasks for VFSBrowser requests, nor access to the BrowserView's model before it has been changed.

1 Attachments

Related

Bugs: #3939

Discussion

  • Alan Ezust

    Alan Ezust - 2016-07-10
    • assigned_to: Matthieu Casanova
    • Group: -->
     
  • Alan Ezust

    Alan Ezust - 2016-07-10

    I reviewed the patch and I think it is ok, but I am also not too familiar with that code yet.
    Unless kpouer has something to say about it, I say it is fine to commit.

     
  • Matthieu Casanova

    Hi, I did look at it a little, but what is the bug that you are trying to fix exactly ?

     
  • Alan Ezust

    Alan Ezust - 2016-07-22
     
  • Matthieu Casanova

    Sorry I just tried and it doesn't work at all on Windows (but it was not working before the patch)

     
  • Alan Ezust

    Alan Ezust - 2017-10-29
    • status: open --> pending-rejected
     
  • Alan Ezust

    Alan Ezust - 2017-10-29

    needs to be tested and working on windows

     

Log in to post a comment.