Menu

#527 ES6 support in javascript mode

none
closed-fixed
None
5
2017-12-30
2016-11-01
Metotron
No

There are some new keywords in Javascript, like 'let', 'of'. May be arrow functions need to be highlighted too.

Discussion

  • Roman Tsourick

    Roman Tsourick - 2017-11-02

    I would appreciate if someone could check the attachment in real life.

     
    • Metotron

      Metotron - 2017-11-03

      Looking good. Thank you. It was too hard for make by myself.

       
      • Roman Tsourick

        Roman Tsourick - 2017-11-04

        Please, make suggestions here if you see that something else should be highlighted. I will try to improve the rules before the file is accepted for production.

         
  • Roman Tsourick

    Roman Tsourick - 2017-11-02
    • assigned_to: Roman Tsourick
     
  • Roman Tsourick

    Roman Tsourick - 2017-11-23

    Please, check this too.
    I made template literals recursive, this is not 100% correct, but better than just solid string.

     
    • Metotron

      Metotron - 2017-11-27

      Yes, with this mode literals looks much better, but jedit can not match brackets pair in this sample: ${this.productID_${this.ffff_${this.formData.name-${this.type + ${Math.random()}}}}}
      It shows that first closing bracket is a pair for the first open bracket.

       
      • Roman Tsourick

        Roman Tsourick - 2017-11-28

        Please, provide a working piece of code. The code:

        var a = `${this.productID_${this.ffff_${this.formData.name-${this.type + ${Math.random()}}}}}`;
        

        gives syntax error.

        Besides, are you sure that nested {} is allowed without backticks? The code seems to be just wrong...

         
        • Metotron

          Metotron - 2017-11-29

          Sooory, I forgot how to use it =)

          `${getvar(`${getvar(`${k}_${l}`)}`)}`
          

          This is correct code with nesting and it displays good. Strange syntax.

           

          Last edit: Metotron 2017-11-29
  • Roman Tsourick

    Roman Tsourick - 2017-12-02
    • summary: Need to add ES6 keywords in Javascript highlighter --> ES6 support in javascript mode
     
  • Roman Tsourick

    Roman Tsourick - 2017-12-02

    The patch includes all the updates: https://sourceforge.net/p/jedit/patches/613/

     
  • Roman Tsourick

    Roman Tsourick - 2017-12-30
    • status: open --> closed-fixed
     

Log in to post a comment.