Menu

#3844 edit - "indent lines" for unsupported modes does nothing

minor bug
open
nobody
5
2013-12-09
2013-11-12
Alan Ezust
No

For modes which do not support it, this action should spit out an informative message either as a dialog or to the activity log, instead of just doing nothing.

Discussion

  • Alan Ezust

    Alan Ezust - 2013-11-12
    • summary: "indent selected lines" doesn't. --> "indent [selected] lines" doesn't.
     
  • Matthieu Casanova

    What action ? You mean indent lines in the edit menu ?

     
  • Alan Ezust

    Alan Ezust - 2013-11-13

    Yes. In an XML file, select a bunch of lines, and invoke "indent lines". Nothing happens.
    If this is because XXX is not defined in the XML edit mode, there should be a message in the statusbar indicating that we need XXX to be defined in XML edit mode for this action to work.

     
  • Matthieu Casanova

    I don't know what XXX means, but for an xml it is normal that it doesn't work, jEdit cannot indent xml files.

     
  • Alan Ezust

    Alan Ezust - 2013-11-13

    if I knew what XXX meant, I would fill it in too. But basically, I think there should be an informative message that explains why this action doesn't work on some modes.

     
  • Alan Ezust

    Alan Ezust - 2013-12-09
    • summary: "indent [selected] lines" doesn't. --> "indent [selected] lines" for unsupported modes does nothing
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1 +1 @@
    -I have no idea what this action does, and only a vague idea of what it is supposed to do, but even so, it doesn't seem to work.
    +For modes which do not support it, this action should spit out an informative message either as a dialog or to the activity log, instead of just doing nothing.
    
     
  • Alan Ezust

    Alan Ezust - 2013-12-09
    • summary: "indent [selected] lines" for unsupported modes does nothing --> edit - "indent lines" for unsupported modes does nothing
     

Log in to post a comment.