#105 Sidenote Fixup does not work

[Richard Tonsing]

Per http://www.pgdp.net/wiki/PPTools/Guiguts/Fixup#Sidenotes

The Fixup> Sidenote Fixup menu item performs global changes throughout the document. It converts "sidenote" to "Sidenote"; and it moves any sidenote that is not already surrounded by blank lines up to precede the paragraph it touches with blank lines above and below it.

The selection actually does nothing other than moving the cursor to the next Sidenote.

Steps:
Select the Fixup menu
Then from the drop down menu select "Sidenote Fixup"

[Anonymous]

It works as expected for me. Are you sure there's anything to fix in your file? Remember to always include a demo file with a bug report.

[Anonymous]

Yes there is.

Sorry here's a demo file. Try it yourself.

[Anonymous]

I can confirm it on this file.

Console output:
Tk::Error: bad text index "" at C:/guiguts/perl/lib/Tk.pm
line 247.
Tk callback for .frame.linenumbertext.frame.textunicode
(menu invoke)

Fixup Sidenote works correctly on some other files. It seems to fail when it reaches a sidenote that's on a line of its own inside a paragraph. If the note is inside the flow of the text it works. It fails and dies when it reaches the first sidenote of this kind.

Some observations:

First run Fixup Sidenotes on holinshed3.txt.
It fixes the first sidenote (1483), and nothing more. Console displays the output quoted above.

Now find the second sidenote (The loue...) and remove the newline at the end of the line (don't need to restart).
Run Fixup Sidenotes again. It now fixes "The loue..." AND the third sidenote (Description of...) which was on a separate line at the beginning of a paragraph, but then nothing more. After finishing, the cursor is left at the last sidenote that was changed.