Menu

#1 can not build on 64bit system

trunk
open-fixed
building (1)
5
2007-08-08
2007-08-08
Halton Huo
No

E: gnome-sync 64bit-portability-issue gs-opensync.c: 1090

Discussion

  • Halton Huo

    Halton Huo - 2007-08-08

    Logged In: YES
    user_id=1569662
    Originator: YES

    1086 for (i = 0; i < count; i++) {
    1087 const gchar *objtype = g_strdup
    (osync_group_nth_objtype(group, i));
    1088 *objtypes = g_list_append (*objtypes, (void *)objtype);
    1089 if (osync_group_objtype_enabled (group, objtype))
    1090 *status = g_list_append (*status, TRUE);
    1091 else
    1092 *status = g_list_append (*status, FALSE);
    1093 }

    On 32 bit system, there will be a compile warning like following:
    "gs-opensync.c", line 1090: warning: improper pointer/integer
    combination: arg #2

    We append a boolean value into GList, the #2 arg need a pointer,
    that my be error on 64 bit system

     
  • Halton Huo

    Halton Huo - 2007-08-08
    • labels: --> building
    • status: open --> open-accepted
     
  • Halton Huo

    Halton Huo - 2007-08-08
    • status: open-accepted --> open-fixed
     
  • Halton Huo

    Halton Huo - 2007-08-08

    Logged In: YES
    user_id=1569662
    Originator: YES

    File Added: gnome-sync-add-bool-to-glist.diff

     
  • Halton Huo

    Halton Huo - 2007-08-08

    patch for this bug

     

Log in to post a comment.

MongoDB Logo MongoDB