Menu

#367 The 'hits_table' (Karyotype.pm) doesn't always respect httpS

v2.0
closed-fixed
Gbrowse (196)
5
2011-06-08
2011-05-10
Dan Bolser
No

The hits_table in Bio/Graphics/Karyotype.pm doesn't always respect httpS:// links. This happens in the 'Position' column of the table, while the 'Name' column gets it right.

I run GBrowse out of a httpS:// URL scheme, and the links under the Name column of the hits_table were correctly showing the httpS:// part of the URL. However, links under the Position column were showing http://, and were therefore dead when clicked on my setup.

I've attached a patch to fix this issue.

Discussion

  • Dan Bolser

    Dan Bolser - 2011-05-10

    The patch. See @@ -358,7 +360,7 @@, other diffs are cosmetic

     
  • Dan Bolser

    Dan Bolser - 2011-05-10

    Bah, my own fault for creating confusing diffs.

    The line of interest is:

    - my $url = url(-path_info=>1)."?name=";
    + my $url = url(-absolute=>1, -path_info=>1)."?name=";

    Ignore my comment about 'See @@ -358,7 +360,7 @@'!

     
  • Scott Cain

    Scott Cain - 2011-05-10
    • assigned_to: scottcain --> lstein
     
  • Lincoln Stein

    Lincoln Stein - 2011-05-10
    • status: open --> open-fixed
     
  • Lincoln Stein

    Lincoln Stein - 2011-05-10

    Thanks. I have incorporated your patch, and it will appear in version 2.34.

     
  • Dan Bolser

    Dan Bolser - 2011-06-08
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB