gaim-bnet lets me add a friend multiple times. This then causes crashes when the bnet prpl initializes the next time, and extraneous instances will need to be manually removed from blist.xml.
We should catch attempts to add the same buddy twice.
Logged In: YES user_id=61900
bnet definitely returns an error, we should be seeing this and not adding a local buddy.
The problem seems to be that we don't check for the buddy first.
We first add the buddy to the local list, then retrieve the remote list and compare the two.
Alright think I have a fix. Calling gaim_blist_remove_buddy() in bnet_buddy_add() if the buddy is already in conn->buddies.
Log in to post a comment.
Logged In: YES
user_id=61900
bnet definitely returns an error, we should be seeing this
and not adding a local buddy.
Logged In: YES
user_id=61900
The problem seems to be that we don't check for the buddy first.
We first add the buddy to the local list, then retrieve the
remote list and compare the two.
Logged In: YES
user_id=61900
Alright think I have a fix. Calling
gaim_blist_remove_buddy() in bnet_buddy_add() if the buddy
is already in conn->buddies.