Stop using XPM icons in the GTK UI

Brought to you by: fredm, pak21

#509 Stop using XPM icons in the GTK UI

Milestone: v1.7.0

Status: closed-fixed

Owner: nobody

Labels: GTK (2)

Priority: 5

Updated: 2 days ago

Created: 2024-10-10

Creator: Alberto Garcia

Private: No

Fuse has a few instances of gdk_pixbuf_new_from_xpm_data() for the icons in the statusbar.

However the latest versions of GdkPixbuf disable the XPM loader by default, see here:

https://discourse.gnome.org/t/change-in-the-gdk-pixbuf-loaders-built-by-default-in-2-42-11/21845

We should convert the icons into something else so they can be displayed correctly in all installations.

Discussion

Alberto Garcia - 2024-10-11

Here is the fix.

I include a second patch that fixes a small memory leak in the tape browser dialog.

Last edit: Alberto Garcia 2024-10-11

0001-Use-PNG-instead-of-XPM-for-the-icons-in-the-GTK-UI.patch

0002-Don-t-leak-tape_marker_pixbuf-when-the-tape-browser-.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Sergio Baldoví - 2024-10-12

Looks good to me.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Sergio Baldoví - 2024-10-19

labels: --> GTK

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Sergio Baldoví - 2024-10-19

Thank you. Committed in [514389].

Related

Commit: [514389]

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Sergio Baldoví - 2024-10-19

Group: future --> NextRelease
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.