#1 Fronsetia throws NullPointerException for a valid WSDL

[Gorazd Hribar Rajterič]

Fronsetia throws NullPointerException.

Detailed information:
1. Fronsetia version 1.1.0
2. JavaEE Server: JBoss EAP 6.4.24.GA (Running on RHEL 8: 4.18.0-513.9.1.el8_9.x86_64)
3. Java: java-1.8.0-openjdk-portable-1.8.0.372.b07-1.portable.jdk.el.x86_64
4. Error log:
Exception caught while parsing the WSDL:

java.lang.NullPointerException
java.lang.NullPointerException
at bogdrosoft.fronsetia.WSDLCheck.processXSD(WSDLCheck.java:375)
at bogdrosoft.fronsetia.WSDLCheck.processWSDL(WSDLCheck.java:293)
at bogdrosoft.fronsetia.WSDLCheck.getOperations(WSDLCheck.java:99)
at org.apache.jsp.show_005foperations_jsp._jspService(show_005foperations_jsp.java:146)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:69)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:847)
at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:365)
at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:313)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:246)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:847)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:295)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:214)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:231)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:149)
at org.jboss.modcluster.container.jbossweb.JBossWebContext$RequestListenerValve.event(JBossWebContext.java:91)
at org.jboss.modcluster.container.jbossweb.JBossWebContext$RequestListenerValve.invoke(JBossWebContext.java:72)
at org.jboss.as.web.security.SubjectInfoSetupValve.invoke(SubjectInfoSetupValve.java:34)
at org.jboss.as.web.security.SecurityContextAssociationValve.invoke(SecurityContextAssociationValve.java:169)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:151)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:97)
at org.apache.catalina.authenticator.SingleSignOn.invoke(SingleSignOn.java:400)
at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:560)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:102)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:856)
at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:656)
at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:926)
at java.lang.Thread.run(Thread.java:750)
5. Steps to reproduce: open URL http://localhost:1080/fronsetia-web-1.1/show_operations.jsp?Fronsetia_WSDL=http://localhost:8080/GiBusinessFiber/GiBusinessFiberWS?wsdl in a browser (Firefox in my case, but happens in Chrome and Safari as well)
6. Problematic WSDL and XSD files are attached
7. I believe that provided information should help solve the problem.

[Gorazd Hribar Rajterič]

Solution is to add a couple of if conditions at the end of WSDLCheck.java as in an attached file.

[Bogdan Drozdowski]

Hello.
Thank you for your report and the suggestion for a fix.
I will check the proposed changes. The changes at the end of the file look reasonably right now, but there may be some deeper "root cause" of the problem - the null values apparently weren't meant to happen at that point, so I'll see if there's something in the WSDL/XSD files (thanks for the attachments!) that causes the issue and wasn't taken into account in my test files.
Since the file contains also formatting changes, I'll need to check if I'm not missing something else (yes, I know that the programming style in my old code is not strictly Java style, maybe I'll change that as well at some time).

[Bogdan Drozdowski]

Hello.
Sorry for the delay, I had some other tasks to finish as well.
To be honest, I was unable to reproduce the problem with the given WSDL+XSD, neither in unit tests, nor the usual way - when serving it through a web server and pointing Fronsetia at it.
Nevertheless, it was nice of you to attach those. I've created yet another unit test thanks to that.
Although I wasn't able to reproduce the problem, I've added some more null checks anyway, as your patch suggested (even more, and in another form, though). These won't hurt.
Version 1.1.1 has just been released with those null checks and it should work out of the box for your case.
Please test when you have time and let me know if it works for you as well.

[Bogdan Drozdowski]

No response for 2 months. Assuming success.