#111 New options: New-colonists and Breeding-control options

[Fenyo]

New options: New-colonists and Breeding-control options
Now we can customize that if we want to make new colonists or not in a colony (per colony and global-default setting),
and we can also customize the breeding of breedable types (eg. horses) in a colony (per colony and global-default setting).
Global settings are in the Colony tab of the Game Options,
and Per colony settings are placed on a new panel on the ColonyPanel: Reproduction

Repositories/Branch:
https://sourceforge.net/u/fenyo1/freecol/ci/Reproduction/
https://github.com/fenyo1/FreeCol/tree/Reproduction

[Mike Pope]

I have several objections to this patch as it stands.

First, I would like to see some reasoning for why you would want to suppress colonist production at all. Very odd idea IMHO. I think it would have been better to discuss this on the developer list.

Second, even if you do have a good reason, I do not see a need for a game option for a boolean value that should always be true.

The game option for the breeding functionality makes more sense, and I think it is a good idea. However this whole area is very sensitive. Changing the code here needs to be done with caution, so I am not immediately going to go all the way to allowing individual colony settings, but am willing to allow a global breeding control so we can check if this breaks anything. Once we are more confident it is working, I will be happy to consider the individual colony settings.

Finally, the patch is way too complex, as it bundles several separable pieces of functionality. If you break it up into individual patches I would be more interested:

[Now] A patch adding the a global breeding game option, and the production code that makes use of it.

[Later] A patch generalizing the breeding behaviour to individual colonies

[When explained] The colonist production suppression