#20 [2.1.0 Test-2] Shaking sprites

[Julian Nechaevsky]

Maybe it was discovered already, but since it was not fixed, I’ll post it here.

Some sprites "shaking" while animation, and it seems to happen because of different width of one or few frames. For example, small blue torch animation sequence have one frame with different width than others, and exactly this frame "C" shakes in game.

Here's how it looks in game: https://youtu.be/MmyLhMVrlP4

List of all problematic objects:

• Eye of Symbol (id 41)
• Short blue torch (id: 55)
• Short green torch (id: 56)
• Short red torch (id: 57)
• Burning barrel (id: 70)

Suggestion: some kind of fixed horizontal alignment/offset is needed for objects in engine itself.

Also was tested on 1.35, 2.0.4 Final and TEST-1 - same problem there.

[Chilly Willy]

I've modified the thing positioning code to be more like fixed point math. It's cured the problem as far as I can tell, having checked all of the listed things except the short red torch. In fixed point, being off by one pixel doesn't affect the calculations. In floating point, it does, and is magnified by the screen scaling. At 320 wide, a half pixel jitter is completely masked by the math. At 640 wide, a half pixel jitter in floating point becomes a full pixel jitter.

[Julian Nechaevsky]

C.W., thank you, left-right shaking has gone in 2.1.0 Released-Test-2.

But now I've noticed another shaking, now it looks likes forward-backward in closer look. Affected objects are same:

• Eye of Symbol (id 41)
• Short blue torch (id: 55)
• Short green torch (id: 56)
• Short red torch (id: 57)
• Burning barrel (id: 70)

Just take a look: https://youtu.be/QVpC4b1m4_s

Or I should start a new ticket for this case?

[Corbin]

Changed from Closed -> Pending. We refactored a bunch of math calls over the last few months that might have something to do with it, but I'm sure we will get it patched up shortly ;)

[Corbin]

This has been finally fixed -- will be in TEST3! ^_^