#203 Tagged lines (doors &c.), no same-tagged sectors, do nothing

[Darren Salt]

Certain line types, when tagged, affect sectors with
the same tag. But if there are no matching sectors,
nothing happens - unlike various other Doom ports
(Legacy & DIY tested here) which cause these lines to
act as if untagged.

The attached patch fixes this for doors, floors and
ceilings; other line types may also need to be fixed.

[Darren Salt]

Make some tagged lines without tagged sectors have an effect.

[Darren Salt]

[Darren Salt]

Logged In: YES
user_id=294680

Test case.

[Andy Baker]

Logged In: YES
user_id=11266

Any reason why we support this apart to conform the other
ports behaviour; Moreover, does any map require this?

[Andrew Apted]

Logged In: YES
user_id=11869

Firstly, I think it is too close to the release to introduce a
significant change to the way linetypes work. There is
not enough time to test it, and I don't want to risk
breaking projects like QDOOM.

That said, it seems Boom supports this (see the P_CheckTag
function in p_spec.c), so it would make sense to support this,
but (a) after the 1.29 release, and (b) use a new command
in DDF to mark which linetypes are affected.

[Andrew Apted]

Logged In: YES
user_id=11869

The patch is not quite right, some linetypes should
ignore their tag completely, namely these ones:

1, 26, 27, 28, 31, 32, 33, 34, 117, 118

which can be done easily by using TYPE=MANUAL
in LINES..DDF (instead of PUSH).

A concrete example is MAP02. Play through it
and open the Blue door. Then go back to the start
area and a ceiling has lowered (you can no longer
go to the red-bars area). That's an EDGE bug.

I'm still not comfortable to "fix" this so close to a
release, for the same reasons given before.

[Andrew Apted]

Logged In: YES
user_id=11869

P.S. the same thing on MAP02 causes the
"extra loud door" problem, as the tag refers
to a whole bunch of sectors, and each of them
plays the opening sound.