Menu

#59 ::selection throws an exception

closed
nobody
None
1
2015-02-11
2014-11-05
mercury
No

Test-case:

::selection{background:green}

This throws an exception:

cz.vutbr.web.css.CSSException: Unable to parse embedded CSS style [AST]
    at cz.vutbr.web.csskit.antlr.CSSParserFactory$SourceType.encapsulateException(CSSParserFactory.java:198)
    at cz.vutbr.web.csskit.antlr.CSSParserFactory$SourceType.access$100(CSSParserFactory.java:46)
    at cz.vutbr.web.csskit.antlr.CSSParserFactory$SourceType$2.parse(CSSParserFactory.java:104)
    at cz.vutbr.web.csskit.antlr.CSSParserFactory.parseAndImport(CSSParserFactory.java:345)
    at cz.vutbr.web.csskit.antlr.CSSParserFactory.parse(CSSParserFactory.java:234)
    at cz.vutbr.web.csskit.antlr.CSSParserFactory.parse(CSSParserFactory.java:262)
Caused by: java.lang.NullPointerException
    at cz.vutbr.web.csskit.antlr.CSSTreeParser.pseudo(CSSTreeParser.java:3634)
    at cz.vutbr.web.csskit.antlr.CSSTreeParser.selpart(CSSTreeParser.java:3088)
    at cz.vutbr.web.csskit.antlr.CSSTreeParser.selector(CSSTreeParser.java:2964)
    at cz.vutbr.web.csskit.antlr.CSSTreeParser.combined_selector(CSSTreeParser.java:2652)
    at cz.vutbr.web.csskit.antlr.CSSTreeParser.ruleset(CSSTreeParser.java:1511)
    at cz.vutbr.web.csskit.antlr.CSSTreeParser.statement(CSSTreeParser.java:565)
    at cz.vutbr.web.csskit.antlr.CSSTreeParser.stylesheet(CSSTreeParser.java:475)
    at cz.vutbr.web.csskit.antlr.CSSParserFactory$SourceType$2.parse(CSSParserFactory.java:99)
    ... 34 more

Discussion

  • mercury

    mercury - 2014-11-05

    Although ::selection is not in w3c standards, it is used in many css files already.

    I think the bigger issue is: Even if jStyleParser doesn't add support for ::selection, it should IMO ignore such rules and gracefully handle the remaining rules.

    Thanks!

     
  • Radek Burget

    Radek Burget - 2014-11-05

    Oops, this was a bug in the declaration testing. It should be fixed now.

     
  • Chetan Kothari

    Chetan Kothari - 2014-11-06

    Thanks for the fix.

    Added supporting test cases and made a PR

     
  • Radek Burget

    Radek Burget - 2014-11-15
    • status: open --> accepted
     
  • Radek Burget

    Radek Burget - 2015-02-11
    • status: accepted --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.