::selection throws an exception
Pure Java HTML / CSS rendering engine
Status: Beta
Brought to you by:
radkovo
Test-case:
::selection{background:green}
This throws an exception:
cz.vutbr.web.css.CSSException: Unable to parse embedded CSS style [AST]
at cz.vutbr.web.csskit.antlr.CSSParserFactory$SourceType.encapsulateException(CSSParserFactory.java:198)
at cz.vutbr.web.csskit.antlr.CSSParserFactory$SourceType.access$100(CSSParserFactory.java:46)
at cz.vutbr.web.csskit.antlr.CSSParserFactory$SourceType$2.parse(CSSParserFactory.java:104)
at cz.vutbr.web.csskit.antlr.CSSParserFactory.parseAndImport(CSSParserFactory.java:345)
at cz.vutbr.web.csskit.antlr.CSSParserFactory.parse(CSSParserFactory.java:234)
at cz.vutbr.web.csskit.antlr.CSSParserFactory.parse(CSSParserFactory.java:262)
Caused by: java.lang.NullPointerException
at cz.vutbr.web.csskit.antlr.CSSTreeParser.pseudo(CSSTreeParser.java:3634)
at cz.vutbr.web.csskit.antlr.CSSTreeParser.selpart(CSSTreeParser.java:3088)
at cz.vutbr.web.csskit.antlr.CSSTreeParser.selector(CSSTreeParser.java:2964)
at cz.vutbr.web.csskit.antlr.CSSTreeParser.combined_selector(CSSTreeParser.java:2652)
at cz.vutbr.web.csskit.antlr.CSSTreeParser.ruleset(CSSTreeParser.java:1511)
at cz.vutbr.web.csskit.antlr.CSSTreeParser.statement(CSSTreeParser.java:565)
at cz.vutbr.web.csskit.antlr.CSSTreeParser.stylesheet(CSSTreeParser.java:475)
at cz.vutbr.web.csskit.antlr.CSSParserFactory$SourceType$2.parse(CSSParserFactory.java:99)
... 34 more
Anonymous
Although
::selection
is not in w3c standards, it is used in many css files already.I think the bigger issue is: Even if jStyleParser doesn't add support for
::selection
, it should IMO ignore such rules and gracefully handle the remaining rules.Thanks!
Oops, this was a bug in the declaration testing. It should be fixed now.
Thanks for the fix.
Added supporting test cases and made a PR