#187 CExplorerBHO::OnNavigateComplete() - Missing NULL checks

[Matt Bush]

Classic shell will crash if...

"classic shell explorer settings" -> "all settings" -> "file pane" -> "show sort headers in all views"

is enabled when navigating to a shell extension that doesn't implement IFolderView2

STDMETHODIMP CExplorerBHO::OnNavigateComplete( IDispatch pDisp, VARIANT URL )
...
CComQIPtr<ifolderview> pFolderView=pView;
if (pFolderView)
{
if (GetSettingBool(L"ShowHeaders"))
{
...
CComQIPtr<ifolderview2> pView2=pFolderView;
// Turn on the sort header!
pView2->SetCurrentFolderFlags(FWF_NOHEADERINALLVIEWS,0);</ifolderview2></ifolderview>

pView2 is not checked for NULL before use.

[Ivo Beltchev]

Thanks for reporting this. Where did you find a shell extension that doesn't support IFolderView2?

[Ivo Beltchev]

This is fixed in version 3.6.2