#179 File Manipulation Error

[Thomas Schanz]

When running the CDE file manager 'dtfile' under Fedora and dragging a folder (not a file) onto the trashcan, I getting an error massage about a 'File Manipulation Error' -> see attachement! The function works, the folder is put into the trash and is deleted in its original location, but there is the error message!

I have figured out that the error message is related to the 'btrfs' file system, the same installation on 'ext4' file system does not have this problem and works correctly! Somehow 'btrfs' which is now the default filesystem on Fedora for a while is not compatible to CDE. I have used a fresh compiled CDE 2.5.2 on Fedora 42, but I see the problem also on Fedora 40/38/34 (all running 'btrfs'), I dont have problems on Ferora34/38/42 running 'ext4' file system. Maybe some one can look into it or put a warning in the installition guidelines of CDE, not to use 'btrfs'.

thanks, and best regards,
Thomas

[Thomas Schanz]

.. seems I forgot the attachement, here it is ...

[Mariusz Zynel]

It was really annoying and I've just fixed this yesterday. There is a function Check() in
programs/dtfile/FileManip.c
that checks if a folder is not being copied into itself. The bug is in the assumption that the filesystem is UFS in case of SVR4 and the inode of / in Linux is 2. The fix that comes to mind is to stat() the root /. See the attached patch.
The inode of root doesn't change over a session, so it should be better called once per session, maybe in dtsession, and used as global variable.

Hope this helps
Mariusz

PS. Nice to see that I'm not alone using CDE