Re: [Bluemusic-devel] NoteProcessorException additions

[Steven Yi <ste...@gm...>]

HI MIchael,

I'm working on building a SoundObjectException at the moment.  Taking
a look at NoteProcessorException, I had a few questions:

1)What do you think about getting rid of the "String processorName"
argument and passing in the noteProcessor?  More information could be
gleaned from that IMO and might be of use later down the road, say,
implementing a "click here to navigate to problem" feature.

2)I've changed the messageFormat to be private static final as it
doesn't help much to use a MessageFormat untess it's going to be
reused.  Any objections?

Thanks!
steven


On Apr 8, 2005 5:42 AM, Michael Bechard <got...@ya...> wrote:
> Yeah, I'm right with ya.  I was thinking about the
> problem of how the user would identify where
> specifically the error occured. Having the SoundObject
> handle NoteProcessor exceptions sounds like the way to
> go.
> 
> And speaking of JUnit, I thought about the JUnit
> tests, but so far I haven't been able to get JUnit to
> work for me. I need to give it another go, though, as
> my efforts haven't been too significant.
> 
> Michael Bechard
> --- Steven Yi <ste...@gm...> wrote:
> 
> > Oh, another thought, regarding having exceptions for
> > SoundObjects: in
> > general usage, noteProcessors can bubble up the
> > exception to the
> > SoundObject, the SoundObject could then throw a
> > SoundObjectException,
> > wrapping the noteProcessor exception as well as
> > having a reference to
> > itself.  That way, we can display information like:
> >
> > "An error happened on SoundObject titled:
> > mySoundObject
> > startTime: 0
> > duration: 10
> > on SoundLayer titled: mylayer
> > Message: message"
> >
> > Or something along those lines.  That would be sort
> > of handy I think.
> > THere could be a PolyObject exception that
> > subclasses
> > SoundObjectException as well, to hold the soundLayer
> > and other
> > information.
> >
> > How does that sound?
> >
> > steven
> >
> >
> > On Apr 7, 2005 8:31 PM, Steven Yi
> > <ste...@gm...> wrote:
> > > Hi MIchael,
> > >
> > > I took a look at the code as I updated from CVS
> > and from first glance
> > > things seemed like they were done just fine.
> > >
> > > The one thing that came to mind was that I have
> > written a very very
> > > small number of JUnit tests, and this would have
> > been good situation
> > > to have had tests written to test against. So,
> > perhaps when I get some
> > > free time I will write some tests against all the
> > noteProcessors and
> > > add to the test suite.
> > >
> > > Thanks very much for this code change!  I think it
> > is a first good
> > > step forward towards having a better error
> > reporting system for users.
> > >
> > > ^_^
> > >
> > > steven
> > >
> > >
> > > On Apr 7, 2005 4:18 PM, Michael Bechard
> > <got...@ya...> wrote:
> > > > I added more robust error handling in all of the
> > > > NoteProcessors.  Two new classes;
> > > > NoteProcessorException and
> > NoteProcessorRTException.
> > > > NoteProcessorException gets thrown in
> > > > NoteProcessor.processNotes.
> > > > ScoreUtilities.applyNoteProcessorChain catches
> > them,
> > > > shows a popup to the user, and bubbles the
> > exception
> > > > further up via NoteProcessorRTException, which
> > is a
> > > > RuntimeException.
> > > >
> > > > I tried to only throw errors on conditions that
> > would
> > > > have caused the CSD generation to not work
> > anyway.
> > > > Please please let me know if I missed anything.
> > > >
> > > > Thanks,
> > > > Michael Bechard
> > > >
> > > > __________________________________
> > > > Do you Yahoo!?
> > > > Make Yahoo! your home page
> > > > http://www.yahoo.com/r/hs
> > > >
> > > >
> >
> -------------------------------------------------------
> > > > SF email is sponsored by - The IT Product Guide
> > > > Read honest & candid reviews on hundreds of IT
> > Products from real users.
> > > > Discover which products truly live up to the
> > hype. Start reading now.
> > > >
> >
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> > > > _______________________________________________
> > > > Bluemusic-devel mailing list
> > > > Blu...@li...
> > > >
> >
> https://lists.sourceforge.net/lists/listinfo/bluemusic-devel
> > > >
> > >
> >
> >
> >
> -------------------------------------------------------
> > SF email is sponsored by - The IT Product Guide
> > Read honest & candid reviews on hundreds of IT
> > Products from real users.
> > Discover which products truly live up to the hype.
> > Start reading now.
> >
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> > _______________________________________________
> > Bluemusic-devel mailing list
> > Blu...@li...
> >
> https://lists.sourceforge.net/lists/listinfo/bluemusic-devel
> >
> 
> __________________________________
> Do you Yahoo!?
> Yahoo! Personals - Better first dates. More second dates.
> http://personals.yahoo.com
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> Bluemusic-devel mailing list
> Blu...@li...
> https://lists.sourceforge.net/lists/listinfo/bluemusic-devel
>