Menu

#7 Tag validation

open
nobody
5
2009-07-07
2009-07-07
vparkhom
No

Not sure if I understood it correctly but according to section 2.2 of a draft http://tools.ietf.org/html/draft-levine-mass-batv-02#section-2.2 tag it seems that tag validation needs to be case insensitive.
If that is the case then in function mlfi_envrcpt(SMFICTX *ctx, char **args) the line that reads if (strcmp(tmp, addr) != 0) may need to be changed to if (strcasecmp(tmp, addr) != 0) .

In addition to that there may be a typo in the same function related to -x switch. It seems that when -x switch is used then all validations fail. Not sure where exactly the typo may be but most likely in line snprintf(tmp, sizeof tmp, "%s+prvs=%1d%03d%02X%02X%02X@%s", tmpaddr, sigversion, sigexpire, digest[0], digest[1], digest[2], at + 1); .

Also, it may be limited to few systems only but version 0.5.0 appear to be unstable and crashes after several minutes on a busy server. Sorry, I have not done any debugging as version 0.4.0 does not seem to have the same problem and runs OK.

Discussion


Log in to post a comment.

MongoDB Logo MongoDB